-
Notifications
You must be signed in to change notification settings - Fork 31
Multipath descriptor support (BIP 389) #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Multipath descriptor support (BIP 389) #275
Conversation
Pull Request Test Coverage Report for Build 16072648456Details
💛 - Coveralls |
Thanks for working on this @schjonhaug. |
Glad to contribute, @ValuedMammal. Let me know if there’s anything I can improve! |
5893601
to
2911658
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this one on, overall your PR looks great. I especially like the detailed docs and new validation to ensure only two indexes are used.
I have two small suggestions and you should do a rebase and then I think it's ready to merge.
2911658
to
7bbada5
Compare
Description
Key Features:
Wallet::create_multipath(descriptor)
following the same pattern ascreate()
andcreate_single()
Usage Example:
Notes to the reviewers
Design Decisions:
make_multipath_descriptor_to_extract()
helper following the same pattern as existingmake_descriptor_to_extract()
functioncreate_multipath()
method returnsCreateParams
just likecreate()
andcreate_single()
, maintaining the fluent builder patternImplementation Notes:
make_multipath_descriptor_to_extract()
twice (once for receive, once for change) which is intentional and follows the established pattern of lazy evaluationChangelog notice
Added:
Wallet::create_multipath()
method for creating wallets from BIP 389 multipath descriptorsCreateParams::new_multipath()
for multipath descriptor parameter creationChecklists
All Submissions:
just p
before pushingNew Features:
Bugfixes:
Closes #11