Skip to content

Conversation

devlifealways
Copy link

@devlifealways devlifealways commented Sep 15, 2025

this commit 0941bbc introduced duplicated label app.kubernetes.io/component, which breaks strict YAML validation.

I think the desired output was meant to have these two labels:

app.kubernetes.io/component: keycloak
app.kubernetes.io/part-of: keycloak

Description of the change

Rename the duplicated lables from

    app.kubernetes.io/component: keycloak
    app.kubernetes.io/component: keycloak

to

    app.kubernetes.io/component: keycloak
    app.kubernetes.io/part-of: keycloak

Benefits

Working YAML validation, on our end we use Kustomize for so much of our applications, and when we build helm based apps using chart version 25.2.0, we have this issue:

image

and after some digging, I found it was due to tls-pass-secret.yaml template having two identical components' label.

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

this commit 0941bbc introduced duplicated
label `app.kubernetes.io/component`, which breaks strict YAML validation.

I think the desired output was meant to have these two labels:

```yaml
app.kubernetes.io/component: keycloak
app.kubernetes.io/part-of: keycloak
```

Signed-off-by: Hamza Rouineb <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
@devlifealways
Copy link
Author

Hi @javsalgar,
Can you look at this ? We really wish to have it ASAP, if there is something else I need to change, just say the word.

Thanks,

@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Sep 16, 2025
@github-actions github-actions bot removed the triage Triage is needed label Sep 16, 2025
@github-actions github-actions bot removed the request for review from javsalgar September 16, 2025 07:31
@github-actions github-actions bot requested a review from gongomgra September 16, 2025 07:31
Signed-off-by: Bitnami Bot <[email protected]>
@devlifealways
Copy link
Author

Perhaps @gongomgra ?

Thanks,

@devlifealways
Copy link
Author

Please @gongomgra can you look at this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress keycloak verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants