deploypulse-codepush-release-react-native 0.0.3 #4390
Conversation
|
|
|
Don't forget to follow semantic versioning! Breaking changes (including step inputs) should be in major versions only.
|
There was a problem hiding this comment.
Thanks for the contribution. Left a few comments for improvements.
These can be most easily fixed by making changes and sending a new steplib PR.
I can defer some changes in case there is a plan for making changes in a later version, I would recommend the ones that change Inputs as they both harder to make later and make using the step easier.
| is_required: true | ||
| title: React Native Project Root | ||
| react_native_project_root: $REACT_NATIVE_PROJECT_ROOT | ||
| - app_id: $APP_ID |
There was a problem hiding this comment.
Please do not use environment variables as the default value.
See our docs https://devcenter.bitrise.io/en/steps-and-workflows/developing-your-own-bitrise-step/developing-a-new-step.html:
Environment Variables must not be used as default values, unless:
- They are exposed by the Bitrise CLI or by bitrise.io.
- They are generated as an output by another Step (for example, $BITRISE_IPA_PATH, $BITRISE_AAB_PATH).
| The platform you want to release the update to. This defaults to ios, but you can specify android if you want to release to the Android platform. | ||
| is_required: true | ||
| title: Platform | ||
| platform: ios |
There was a problem hiding this comment.
I beleive you can use value_options to specify list on valid inputs (ios, android).
| - deployment: Staging | ||
| opts: | ||
| description: | | ||
| This specifies which deployment you want to release the update to. This defaults to Staging, but when you're ready to deploy to Production, or one of your own custom deployments, just explicitly set this argument. See [here](https://docs.microsoft.com/en-us/appcenter/distribution/codepush/cli#deployment-name-parameter) for details. |
There was a problem hiding this comment.
Linking to appcenter docs is still alright, but would recommend migrating away in a next Step release as it may be removed with App Center deprecation.
| To sign your new update in codepush, '$SIGN_PRIVATE_KEY' must be the one who stores your private key to sign | ||
| is_required: false | ||
| title: Signed update | ||
| private_key: -k $SIGN_PRIVATE_KEY |
There was a problem hiding this comment.
We could make this input easier to use with Bitrise.
- The easiest to use option would be to accept a remote URL as an input (optionally a local file path too). That way the input can be set on the UI using generic file storage as a source (And fetched using wget in the step.sh https://devcenter.bitrise.io/en/builds/managing-build-files/using-files-in-your-builds.html). Would also remove the
-kflag and move it to the step.sh instead. - Keep the local file path requirement, but would add a description on how can use file-downloader or Script step to fetch the key file.
| @@ -0,0 +1,94 @@ | |||
| title: AppCenter CodePush Release React Native | |||
There was a problem hiding this comment.
| title: AppCenter CodePush Release React Native | |
| title: Release React Native with DeployPulse / AppCenter |
Suggesting slightly more readable title.
| inputs: | ||
| - opts: | ||
| description: | | ||
| Path where the React Native project is located. |
There was a problem hiding this comment.
Please add summary for all inputs. To check that they are displayed correctly you can use (bitrise :workflow-editor command locally)
What to do if the build fails?
At the moment contributors do not have access to the CI workflow triggered by StepLib PRs. In case of a failed build, we ask for your patience. Maintainers of Bitrise Steplib will sort it out for you or inform you if any further action is needed.
New Pull Request Checklist
Please mark the points which you did / accept.
bitrise run test(in the step's repository)bitrise run audit-this-step(in the step's repository - note, if you don't have this workflow in yourbitrise.yml, you can copy it from the step template.)New Step
Thank you for the new Step share! The CI check might will fail due to our extended validation engine. Nothing to worry about yet, we will get back to you shortly.