Flaky failure #226
Open
Flaky failure #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export test results to Test Reports add-on (multi_level_UI_tests) Test Results🛑 3 out of 17 tests have failed!testFailMetestFailMe()testFailMe2() |
|
|
|
|
# Conflicts: # test/converters/converters_test.go # test/converters/junitxml/junitxml.go # test/converters/junitxml/junitxml_test.go # test/converters/junitxml/models.go # test/converters/xcresult3/action_invocation_record.go # test/junit/xml.go # test/test.go # test/testreport/test_report.go
Export test results to Test Reports add-on (multi_level_UI_tests) Test Results🛑 3 out of 17 tests have failed!testFailMetestFailMe()testFailMe2() |
|
|
Export test results to Test Reports add-on (multi_level_UI_tests) Test Results🛑 3 out of 17 tests have failed!testFailMetestFailMe()testFailMe2() |
|
|
molnarm
reviewed
Jun 27, 2025
|
|
||
| for _, rerunError := range testCase.RerunErrors { | ||
| flattenedTestCase.Failure = convertRerunErrorToFailure(rerunError) | ||
| flattenedTestCases = append(flattenedTestCases, flattenedTestCase) |
There was a problem hiding this comment.
convertXXXToFailure is the same code 4x (insert rant about Go "interfaces").
Could we maybe replace them/delegate to something like convertToFailure(type, message, systemErr string)?
| Failure: nil, | ||
| Skipped: nil, | ||
| Error: nil, | ||
| FlakyFailures: nil, |
There was a problem hiding this comment.
If you want to be explicit about leaving these empty, also add FlakyErrors and RetryErrors.
Or just leave them all out.
tothszabi
reviewed
Jun 27, 2025
Comment on lines
+124
to
+129
| Time: 0, | ||
| Failure: nil, | ||
| Skipped: nil, | ||
| Error: nil, | ||
| FlakyFailures: nil, | ||
| RerunFailures: nil, |
There was a problem hiding this comment.
I think you do not need to explicitly set these and omit them because they will be initialised to their default value which are what you just described here.
Comment on lines
+156
to
+262
| message += ": " | ||
| } | ||
| message += flakyFailure.Message | ||
| } | ||
|
|
||
| if len(strings.TrimSpace(flakyFailure.SystemErr)) > 0 { | ||
| if len(message) > 0 { | ||
| message += "\n\n" | ||
| } | ||
| message += "System error:\n" + flakyFailure.SystemErr | ||
| } | ||
|
|
||
| if len(message) > 0 { | ||
| return &Failure{ | ||
| Value: message, | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func convertFlakyErrorToFailure(flakyError FlakyError) *Failure { | ||
| var message string | ||
| if len(strings.TrimSpace(flakyError.Type)) > 0 { | ||
| message = flakyError.Type | ||
| } | ||
| if len(strings.TrimSpace(flakyError.Message)) > 0 { | ||
| if len(message) > 0 { | ||
| message += ": " | ||
| } | ||
| message += flakyError.Message | ||
| } | ||
|
|
||
| if len(strings.TrimSpace(flakyError.SystemErr)) > 0 { | ||
| if len(message) > 0 { | ||
| message += "\n\n" | ||
| } | ||
| message += "System error:\n" + flakyError.SystemErr | ||
| } | ||
|
|
||
| if len(message) > 0 { | ||
| return &Failure{ | ||
| Value: message, | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func convertRerunFailureToFailure(rerunFailure RerunFailure) *Failure { | ||
| var message string | ||
| if len(strings.TrimSpace(rerunFailure.Type)) > 0 { | ||
| message = rerunFailure.Type | ||
| } | ||
| if len(strings.TrimSpace(rerunFailure.Message)) > 0 { | ||
| if len(message) > 0 { | ||
| message += ": " | ||
| } | ||
| message += rerunFailure.Message | ||
| } | ||
|
|
||
| if len(strings.TrimSpace(rerunFailure.SystemErr)) > 0 { | ||
| if len(message) > 0 { | ||
| message += "\n\n" | ||
| } | ||
| message += "System error:\n" + rerunFailure.SystemErr | ||
| } | ||
|
|
||
| if len(message) > 0 { | ||
| return &Failure{ | ||
| Value: message, | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func convertRerunErrorToFailure(rerunError RerunError) *Failure { | ||
| var message string | ||
| if len(strings.TrimSpace(rerunError.Type)) > 0 { | ||
| message = rerunError.Type | ||
| } | ||
| if len(strings.TrimSpace(rerunError.Message)) > 0 { | ||
| if len(message) > 0 { | ||
| message += ": " | ||
| } | ||
| message += rerunError.Message | ||
| } | ||
|
|
||
| if len(strings.TrimSpace(rerunError.SystemErr)) > 0 { | ||
| if len(message) > 0 { | ||
| message += "\n\n" | ||
| } | ||
| message += "System error:\n" + rerunError.SystemErr | ||
| } | ||
|
|
||
| if len(message) > 0 { | ||
| return &Failure{ | ||
| Value: message, | ||
| } | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
These are identical functions with different parameter type but the used variables are the same on that given type.
We could simplify this by receiving the actual variables as parameters:
func convertToFailure(itemType, failureMessage, systemErr string) *Failure {
var message string
if len(strings.TrimSpace(itemType)) > 0 {
message = itemType
}
if len(strings.TrimSpace(failureMessage)) > 0 {
if len(message) > 0 {
message += ": "
}
message += failureMessage
}
if len(strings.TrimSpace(systemErr)) > 0 {
if len(message) > 0 {
message += "\n\n"
}
message += "System error:\n" + systemErr
}
if len(message) > 0 {
return &Failure{
Value: message,
}
}
return nil
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Requires a MINOR version update
Context
This PR adds support for the JUnit report format described for Maven Surefire. The
flakyFailure,flakyError,rerunFailureandrerunErrorelements are converted into a test case with failure preserving the order of test case runs.