Skip to content

Better unit tests #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 19, 2021
Merged

Better unit tests #13

merged 16 commits into from
Mar 19, 2021

Conversation

biw
Copy link
Owner

@biw biw commented Mar 17, 2021

👷 WORK IN PROGRESS 🚧

This PR adds more (and better) unit tests to Nuts. Basically download and updates will be correctly unit tested to avoid breaking changes when trying to contribute to the repository.

This PR will also add standard HTTP status codes to responses, and fix #56.

I was hoping to move code to ES6 (cleaner code, especially for classes) and use Babel before npm releases, but I can't find a solution to make it work correctly while supporting the Heroku Deploy button (I'm open to ideas!).

I'll release a new version 🚀 as soon as all endpoints are correctly tested, and once I'm sure merging #95 did not break Nuts for GitBook and other devs.

XOXO 💕

From GitbookIO/nuts#100

@biw biw force-pushed the GitbookIO/unit-tests branch from a74d6ef to 8eb16b8 Compare March 18, 2021 22:09
@biw biw merged commit 590a882 into main Mar 19, 2021
@biw biw deleted the GitbookIO/unit-tests branch March 19, 2021 02:32
@biw
Copy link
Owner Author

biw commented Mar 19, 2021

Need to double-check that this solves GitbookIO/nuts#102 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants