test: adjust mocks #22
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR was supposed to be small but there were some related things that also needed to get fixed including:
logs.routes.test.ts
so that the tests passThe mocks are partially fixed I think, though I think there should be a general once over for the integration tests or just the testing strategy in general. For the integration tests I think we should mock less/hit the actual backend instead of mocking some stuff out. Could be that we just need more seed data to properly test different scenarios but I'm not super knowledgeable on proper testing strategy for backend systems so I need to read up.
The outcome of this PR did fix the issue in #19 though so we should be good.
Related Issues
Resolves #19
Changes Made
How to Test
docker compose up -d
npm run test:docker
tests should pass
Checklist
Before submitting your PR, ensure you’ve completed the following:
npm run lint
and resolved any warnings/errors.