chore: silence UART on begin #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-subtree-dir: src/note-c git-subtree-split: 022e83c8e54d72edf01502dc9b7bcd3be1d0d9c5
Bucknalla
approved these changes
Jun 3, 2025
haydenroche5
added a commit
to blues/note-c
that referenced
this pull request
Jul 10, 2025
In this PR, we removed code that automatically called card.aux.serial with ms and max parameters to add flow control for AUX serial comms in note-arduino: blues/note-arduino#141 It turns out these tests were relying on that behavior in order to not have Notecard responses over AUX serial wind up corrupted. This corruption was manifesting as CRC errors on the responses. I saw with a logic analyzer that the Notecard was sending the correct response, but that note-c/the Swan was not receiving it correctly. So the fix is to restore the card.aux.serial request with the old ms and max parameters by adding it to the test.
haydenroche5
added a commit
to blues/note-c
that referenced
this pull request
Jul 11, 2025
In this PR, we removed code that automatically called card.aux.serial with ms and max parameters to add flow control for AUX serial comms in note-arduino: blues/note-arduino#141 It turns out these tests were relying on that behavior in order to not have Notecard responses over AUX serial wind up corrupted. This corruption was manifesting as CRC errors on the responses. I saw with a logic analyzer that the Notecard was sending the correct response, but that note-c/the Swan was not receiving it correctly. So the fix is to restore the card.aux.serial request with the old ms and max parameters by adding it to the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove mandatory chatter from serial
begin()method, and updatenote-cto provideNoteAuxSerialFlowControl().