Skip to content

Fix critical buffer overflow vulnerability in Bluetooth REPL #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

Fix critical buffer overflow vulnerability in Bluetooth REPL #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions source/application/luaport.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ static volatile char repl_buffer[BLE_PREFERRED_MAX_MTU];

void lua_write_to_repl(uint8_t *buffer, uint8_t length)
{
// Bounds check to prevent buffer overflow (CVE-PENDING)
// Buffer size is BLE_PREFERRED_MAX_MTU (247), length can be 0-255
if (length >= BLE_PREFERRED_MAX_MTU)
{
length = BLE_PREFERRED_MAX_MTU - 1; // Reserve space for null terminator
}

// Loop copy because memcpy isn't compatible with volatile
for (size_t buffer_index = 0; buffer_index < length; buffer_index++)
{
Expand Down