Fix ambiguous column references in spatial queries #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this adds a missing alias in complex joins involving geometry columns. if a geometry column is referenced multiple times the alias is necessary to prevent ambigous column reference error. |
0xTim
requested changes
Jul 8, 2025
|
id need this to merge. |
Resolves an issue where column references were becoming ambiguous in complex joins involving geometry columns. This change modifies the path generation to explicitly qualify columns with their schema or table alias, replacing the previous approach that created unqualified column names. Specifically, we now prepend the schema or alias name with a dot separator before the column path, ensuring proper SQL column qualification. This prevents errors like "column reference is ambiguous" when using spatial functions on tables with similar column names in multi-table joins. Signed-off-by: bwdmr <[email protected]>
|
the warnings it seemed i couldnt remove due to errors appearing once i remove any unused members from the the errors appearing on psql about sensitive data leakage are presumably a disabled postgis extension manually enabled. afaik it doesnt harm to enable the extension twice, except i am mistaken and it is something else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue where column references were becoming ambiguous in complex joins involving geometry columns. This change modifies the path generation to explicitly qualify columns with their schema or table alias, replacing the previous approach that created unqualified column names. Specifically, we now prepend the schema or alias name with a dot separator before the column path, ensuring proper SQL column qualification.
This prevents errors like "column reference is ambiguous" when using spatial functions on tables with similar column names in multi-table joins.