Skip to content

Keep CLI args as priority #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Keep CLI args as priority #869

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0e0494e
Keep CLI args as priority
RutvikChandla Sep 18, 2024
b7a1ba1
Bump cli version
RutvikChandla Sep 18, 2024
80b0293
fix video_config
RutvikChandla Oct 7, 2024
d874319
Update package.json
RutvikChandla Oct 7, 2024
aa2e3c5
Merge branch 'master' into APS-12458-make-video-cap-consistent-across…
ShashankG-Gollapally Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions bin/helpers/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1368,6 +1368,22 @@ exports.setVideoCliConfig = (bsConfig, videoConfig) => {
if(this.isUndefined(user_cypress_version) || this.isUndefined(cypress_major_version) || parseInt(cypress_major_version) >= 13 ) {
let video_args = `video=${videoConfig.video},videoUploadOnPasses=${videoConfig.videoUploadOnPasses}`;
config_args = this.isUndefined(config_args) ? video_args : config_args + ',' + video_args;
let params = config_args.split(",");
const finalParamsHash = {};

for (let i = 0; i < params.length; i++) {
const param = params[i].split('=');
if (finalParamsHash[param[0]] == undefined) {
finalParamsHash[param[0]] = param[1];
}
};

const arr = [];
for (const [key, value] of Object.entries(finalParamsHash)) {
arr.push(`${key}=${value}`);
}
config_args = arr.join(",");
videoConfig["video"] = finalParamsHash["video"];
logger.debug(`Setting default video true for cypress 13 and above in cli for cypress version ${user_cypress_version} with cli args - ${config_args}`)
}
if (bsConfig.run_settings && this.isNotUndefined(config_args)) bsConfig["run_settings"]["config"] = config_args;
Expand Down
Loading