Improve run.py of regression #4417
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Septa2112
commented
Jun 26, 2025
Septa2112
commented
- Fix script interruption on case failure
- improve statistics logic
- enable select specific issue ids
1. Fix script interruption on case failure 2. improve statistics logic 3. enable select specific issue ids
Septa2112
requested review from
loganek,
lum1n0us,
no1wudi,
TianlongLiang,
wenyongh,
xujuntwt95329 and
yamt
as code owners
TianlongLiang
approved these changes
Jun 27, 2025
lum1n0us
approved these changes
Jun 27, 2025
|
|
||
| selected_ids = None | ||
| if args.issues: | ||
| selected_ids = [int(x) for x in args.issues.split(",") if x.strip().isdigit()] |
There was a problem hiding this comment.
If I recall correctly, --type=list can do the trick. But might still need to convert str to int.
| issue_ids_should_test if issue_ids_should_test else "no more" | ||
|
|
||
| format_issue_ids_should_test = ( | ||
| " ".join("#" + str(x) for x in issue_ids_should_test) |
There was a problem hiding this comment.
Just a hint, usually, using f-strings has better performance than string concatenation.
| else "no more" | ||
| ) | ||
| format_json_only_ids = ( | ||
| " ".join("#" + str(x) for x in json_only_ids) if json_only_ids else "no more" |
There was a problem hiding this comment.
Just a hint, usually, using f-strings has better performance than string concatenation.
| print(f"==== Test results ====") | ||
| print(f" Total: {total}") | ||
| print(f" Total: {total}") |
There was a problem hiding this comment.
you might want to add one more space before Total: and let all three lines aligned at : and remove the space before {total}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.