refactor: refactor the domain / cli commands for active-active's cluster-attr #7299
+245
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Porter <[email protected]>
davidporter-id-au
requested review from
Shaddoll,
neil-xie,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
davidporter-id-au
changed the title
Shaddoll
reviewed
Oct 6, 2025
|
|
||
| if isActiveActiveDomain && len(activeClustersByRegion) == 0 { | ||
| return nil, commoncli.Problem("Option --active_clusters_by_region is required for active-active domain.", nil) | ||
| out.AttributeScopes[attribute].ClusterAttributes[scope] = types.ActiveClusterInfo{ActiveClusterName: name} |
There was a problem hiding this comment.
we might check duplication and return an error here
There was a problem hiding this comment.
yeah, I think my impl is a bit loose. let me add a bit more validation
Signed-off-by: David Porter <[email protected]>
Signed-off-by: David Porter <[email protected]>
Signed-off-by: David Porter <[email protected]>
Signed-off-by: David Porter <[email protected]>
| FailoverInfo *FailoverInfo `json:"failoverInfo,omitempty"` | ||
| } | ||
|
|
||
| func (v *DomainReplicationConfiguration) GetActiveClusters() (o *ActiveClusters) { |
There was a problem hiding this comment.
this is not new, it's just shuffled from below due to my removing and then re-adding it. Happy to put it back in it's previous spot if necessary
|
|
||
| activeClusterName := "" | ||
| if c.IsSet(FlagActiveClusterName) { | ||
| if isActiveActiveDomain { |
There was a problem hiding this comment.
i.. am not actually sure what the behaviour here should be
Shaddoll
approved these changes
Oct 7, 2025
davidporter-id-au
merged commit 1270692
into
cadence-workflow:master
55 of 56 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This is changing the cli to update the cluster-attributes for active/active clusters. This allows domains to update the domain by passing in the format
<cluster-attr>.<scope>:<name>ie:region.manilla:cluster0,region.newyork:cluster1'Why?
How did you test it?
Potential risks
Release notes
Documentation Changes