chore(histograms): dual-emitting persistence latency timers as histograms, by far our largest ones #7305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rams Signed-off-by: Steven L <[email protected]>
Groxx
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Signed-off-by: Steven L <[email protected]>
davidporter-id-au
approved these changes
Oct 7, 2025
timl3136
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
persistence_latency_per_shardis by far our largest series-count timer (metric overall probably), at 37 million series internally.Migrating this to histograms will raise that cardinality significantly, so it'll be a bit of an exciting one, though it's expected to go smoothly.
Since they're nearby and clearly related, I'm also migrating other histograms that cover persistence latency.
These are "large" too, but nearly an order of magnitude smaller.
And
PersistenceLatencyHistogram(manual buckets) has been renamed toPersistenceLatencyManualHistogramand deprecated - the buckets / precision are not changing very much, but the new buckets are subsettable.This will be dual-emitted for "a while", but since the new buckets are so similar it should be very simple to migrate. It's unlikely to be more than a simple name change in queries.
Given the number of series involved in these timers/histograms, this should probably not be merged without also merging #7298 so they can be disabled if needed.
Signed-off-by: Steven L [email protected]