Skip to content

update-payjoin #2281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

update-payjoin #2281

wants to merge 11 commits into from

Conversation

konstantinullrich
Copy link
Contributor

Description

Upgrade Payjoin from v0.21 to v0.23

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods
  • Manual tests in accessibility mode (TalkBack on Android) passed

@konstantinullrich konstantinullrich marked this pull request as ready for review May 22, 2025 15:03
OmarHatem28
OmarHatem28 reviewed May 23, 2025
View reviewed changes
cw_bitcoin/lib/payjoin/payjoin_receive_worker.dart
Comment on lines -119 to +121
final req = await finalProposal.extractV2Req();
final req = await finalProposal.extractReq(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be extractV2Req

@MrCyjaneK
Copy link
Collaborator

MrCyjaneK commented May 23, 2025 •
edited
Loading

@konstantinullrich can we as a part of this PR also make it so payjoin won't require nightly rust toolchain to compile android apk and pin it to a specific version instead? There is a significant chance it will break randomly in future.

INFO: Installing Rust toolchain: nightly
INFO: Installing Rust target: armv7-linux-androideabi
INFO: Building payjoin_flutter for armv7-linux-androideabi
INFO: Installing Rust target: aarch64-linux-android
INFO: Building payjoin_flutter for aarch64-linux-android

@konstantinullrich
Copy link
Contributor Author

Maybe @DanGould can check your suggestion @MrCyjaneK

@DanGould
Copy link

rust-payjoin is 1.63 MSRV so it should be no problem using a pinned version. FRB might be what pushes msrv up.

@MrCyjaneK MrCyjaneK force-pushed the update-payjoin branch 2 times, most recently from 80868a0 to fe774b0 Compare June 5, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarHatem28 OmarHatem28 OmarHatem28 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Work in Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@konstantinullrich @MrCyjaneK @DanGould @OmarHatem28