added missing nc command #415
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
reviewed
Apr 10, 2025
There was a problem hiding this comment.
See inline comments, but it'S just a NIT.
I'd also suggest to introduce "set -e" to the top of start.sh to avoid such issues in the future. I assume that the error nc command is missing! was present in all logs but forever ignored because it did not cause the start script to exit.
|
|
||
| RUN apt-get update \ | ||
| && apt-get install -y netcat-openbsd \ | ||
| && apt-get clean \ |
There was a problem hiding this comment.
The clean should not be required anymore, as all major debian based images have apt hooks that perform a clean automatically. Only the "rm -rf" is required nowadays.
|
This should no longer be an issue. Please reopen if it is! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The netcat command is missing in
wait-for-it.sh.When using the official docker container
start.shscript has a race condition:scripts/wait-for-it.sh ${DATABASE_HOST} -- echo "database is up"is not blocking the execution of the start process - the migrate command fails.I think it was not discovered during your regular development process, as the database is always created during build time
RUN yarn db-deploy.My patch hopefully fixes the root cause of the official docker images.