https://srveditorial-st11.itunes.apple.com/WebObjects/SRVEditorial.woa/wa/debug?store=sundance-root&key=SF6_132006_143503 #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edge compatibility
This will help a lot as the extension gets more complex.
Added Gulp build system
Much more cleanup to go but this is a good start.
Added basic theme support and did a substantial code cleanup
Added remainder of themes based on Ace Cloud Editor
Also reworked some more code around theme switching and messaging.
Fixes callumlocke#100 Also some clean-ups in content.js around messaging, detection and display timing.
Parse text-only pages that have text/html mimetypes
Also: - Fixed incorrect name for Kuroir theme. If you had this theme selected it will reset to Dawn until you change it. - Fixed incorrect name for Tomorrow Night Bright theme. If you had this theme selected it will still work. - Removed stray console.log on page load. - Tweaks around CSS tooling.
Added line numbers
…-and-arrays Fixed doubled line numbers on empty objects and arrays
Pros: - Handles numbers of an unlimited size - No re-ordering of hash keys Cons: - Larger package size due to dependencies - Fractionally longer processing time on very long content
Switched to tokenizer over browser parse
This is to prevent it being blocked on sites with CSP headers.
- Display empty objects and arrays without formatting
This reverts commit 2714179.
- Display empty objects and arrays without formatting
Empty object fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.