-
Notifications
You must be signed in to change notification settings - Fork 73
OpenVPN: fix guide for Ubuntu 24.04+ #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OpenVPN: fix guide for Ubuntu 24.04+ #296
Conversation
d480fda
to
acb3df7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this! Comments in the diff, some questions, some requests for changes.
1d27094
to
0c4f719
Compare
Avoid the following OpenVPN deprecation notice while generating the key: DEPRECATED OPTION: The option --secret is deprecated. WARNING: Using --genkey --secret filename is DEPRECATED. Use --genkey secret filename instead. In short: #Bad: 'sudo openvpn --genkey --secret ta.key' #Good: 'sudo openvpn --genkey secret ta.key' Ref canonical#216
If you get this error: TLS Error: cannot locate HMAC in incoming packet from ... Very probably you will appreciate the added entry in the troubleshooting list. Ref canonical#216
0c4f719
to
693a975
Compare
Thanks for your round of review and enjoy the new commit history 👍 I've solved all change requests and also fixed a pending problem was just mentioned in the issue, about minimal environments like Ubuntu official Docker images. I tried to be nice and still mention the old stuff from Ubuntu 20.04 since it's still under Expanded Security Maintenance (?) but feel free to kill that paragraph violently, if the policy is to don't mention Ubuntu 20.04 anymore. I kept that block since it costs nothing for me to keep it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution! i've added an improvement idea, apart from that i think this is ready to ship 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! I think the only remaining point is the server.conf/client.conf compression. If 22.04 and 24.04 are the same, then we just need one set of instructions, and don't worry about 20.04 and earlier.
> ```bash | ||
> echo 'path-include=/usr/share/doc/openvpn/examples/*' > /etc/dpkg/dpkg.cfg.d/my-openvpn | ||
> apt install --reinstall openvpn | ||
> ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the right place for this information. Nowhere else in the server guide do we talk about how to tweak such minimal environments when describing a particular service. If we want to go down this route, I believe it's better to document such steps in a separate entry in the server guide, perhaps near the installation docs, or even a new one that talks about minimal images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Could I try mentioning this in the troubleshooting section, in a line, very shortly? 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think suggesting to change your ubuntu installation just to fetch these sample config files is overkill. How about a link to fetch these from the internet? We could link directly to the package git repository. For example, those example files can be seen here: https://git.launchpad.net/ubuntu/+source/openvpn/tree/sample/sample-config-files?h=applied/ubuntu/noble-devel
We can link directly:
These are stable links guaranteed to always point at these files from the latest release of openvpn for Ubuntu Noble 24.04.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Damn GitHub, I thought I'd already sent these)
> ```bash | ||
> echo 'path-include=/usr/share/doc/openvpn/examples/*' > /etc/dpkg/dpkg.cfg.d/my-openvpn | ||
> apt install --reinstall openvpn | ||
> ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Could I try mentioning this in the troubleshooting section, in a line, very shortly? 👍
Lots of updates in this PR, nice! Taking a look! |
Hi @valerio-bozzolan, are you still interested in working on this PR? |
Description
Fix all the small issues described in #216 for OpenVPN in Ubuntu 24.04. In order of importance:
/usr/share/doc/openvpn
DEPRECATED OPTION: The option --secret is deprecated.
»Related Issue
Merge Strategy
I suggest to do not squash the commits, since each commit has meaningful details for the benefit of future 'git blame'. Therefore I suggest to merge as fast-forward (or merge commit). You're welcome! 👍 lol
Checklist