Skip to content

Conversation

@szinta
Copy link
Contributor

@szinta szinta commented Sep 29, 2025

closes #8285, #73

In addition to resolving the above issues, this PR also includes the below changes:

  • lock the ESLint and TypeScript versions to address a linting error caused by version incompatibility
  • replace cds-side-panel with c4p-side-panel in Row click example as cds-side-panel is deprecated
  • fix the issue in the Filter flyout example where the flyout does not appear when the trigger icon is clicked

Fixed icon import issue in below listed examples:

@carbon/web-components version updated to "latest" from 2.27.1 and fixed icon import issue in below listed examples:

@szinta szinta added the help wanted 👐 Extra help needed or good for contribution label Sep 30, 2025
@szinta
Copy link
Contributor Author

szinta commented Sep 30, 2025

@matthewgallo Could you please help me resolve the lint error in this PR? I'm not sure how to configure tsconfigRootDir. Also, I'm curious why this lint error started appearing all of a sudden.

@matthewgallo
Copy link
Member

matthewgallo commented Sep 30, 2025

@szinta, I pinned typescript-eslint and removed the feature flag in our lint script. From what I can see, there is a version compatibility issue between eslint and typescript-eslint. Pinning fixes it for now but we should re-visit later so we don't have to pin versions.

I also pinned typescript to a version within the range of supported versions for eslint.

@szinta szinta removed the help wanted 👐 Extra help needed or good for contribution label Oct 1, 2025
@szinta szinta marked this pull request as ready for review October 3, 2025 08:31
@szinta szinta requested a review from matthewgallo October 3, 2025 08:31
Copy link
Member

@matthewgallo matthewgallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here 🎉

@matthewgallo matthewgallo merged commit 437076c into carbon-design-system:main Oct 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tanstack webcomponent examples throwing icon import error with the latest carbon package

2 participants