Skip to content

feat(bezier-tokens): update alpha color token values #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: alpha
Choose a base branch
from
+94 −98
Draft

feat(bezier-tokens): update alpha color token values #2590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 19 additions & 21 deletions packages/bezier-tokens/src/alpha/functional/dark-theme/color.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"type": "color"
},
"dark": {
"value": "{blue.300}",
"value": "{blue.200}",
"type": "color"
}
},
Expand All @@ -56,7 +56,7 @@
"type": "color"
},
"dark": {
"value": "{cobalt.300}",
"value": "{cobalt.200}",
"type": "color"
}
},
Expand All @@ -70,7 +70,7 @@
"type": "color"
},
"dark": {
"value": "{red.300}",
"value": "{red.200}",
"type": "color"
}
},
Expand All @@ -84,7 +84,7 @@
"type": "color"
},
"dark": {
"value": "{orange.300}",
"value": "{orange.200}",
"type": "color"
}
},
Expand All @@ -98,7 +98,7 @@
"type": "color"
},
"dark": {
"value": "{green.300}",
"value": "{green.200}",
"type": "color"
}
},
Expand All @@ -112,7 +112,7 @@
"type": "color"
},
"dark": {
"value": "{teal.300}",
"value": "{teal.200}",
"type": "color"
}
},
Expand All @@ -126,7 +126,7 @@
"type": "color"
},
"dark": {
"value": "{olive.300}",
"value": "{olive.200}",
"type": "color"
}
},
Expand All @@ -140,7 +140,7 @@
"type": "color"
},
"dark": {
"value": "{yellow.300}",
"value": "{yellow.200}",
"type": "color"
}
},
Expand All @@ -154,7 +154,7 @@
"type": "color"
},
"dark": {
"value": "{pink.300}",
"value": "{pink.200}",
"type": "color"
}
},
Expand All @@ -168,7 +168,7 @@
"type": "color"
},
"dark": {
"value": "{purple.300}",
"value": "{purple.200}",
"type": "color"
}
},
Expand All @@ -182,7 +182,7 @@
"type": "color"
},
"dark": {
"value": "{navy.300}",
"value": "{navy.200}",
"type": "color"
}
},
Expand Down Expand Up @@ -276,7 +276,7 @@
"bg": {
"black": {
"darkest": {
"value": "{black.60}",
"value": "{white.60}",
"type": "color"
},
Comment on lines +279 to 281
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

bg.black.darkest 가 흑색 → 백색 계열로 변경됨

{black.60} → {white.60} 변경은 의미상 “어두운 배경” 토큰이 중간 투명도의 흰색으로 바뀐 것입니다.
특정 컴포넌트가 이 토큰을 반전 용도로 사용한다면 의도치 않게 밝아질 수 있으니 디자인 팀과 취지 재확인 부탁드립니다.

🤖 Prompt for AI Agents 
In packages/bezier-tokens/src/alpha/functional/dark-theme/color.json around
lines 279 to 281, the color value for bg.black.darkest was changed from
"{black.60}" to "{white.60}", which alters the token from a dark black shade to
a lighter white shade. Review this change with the design team to confirm the
intent, especially if any components rely on this token for inversion effects,
and revert or adjust the color value accordingly to maintain the intended dark
background appearance.

"darker": {
Expand Down Expand Up @@ -858,15 +858,13 @@
}
},
"dim": {
"black": {
"light": {
"value": "{bg.absolute.black.lightest}",
"type": "color"
},
"normal": {
"value": "{bg.absolute.black.lighter}",
"type": "color"
}
"light": {
"value": "{bg.absolute.black.lightest}",
"type": "color"
},
"normal": {
"value": "{bg.absolute.black.lighter}",
"type": "color"
}
}
}
16 changes: 7 additions & 9 deletions packages/bezier-tokens/src/alpha/functional/light-theme/color.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,15 +858,13 @@
}
},
"dim": {
"black": {
"light": {
"value": "{bg.absolute.black.lightest}",
"type": "color"
},
"normal": {
"value": "{bg.absolute.black.lighter}",
"type": "color"
}
"light": {
"value": "{bg.absolute.black.lightest}",
"type": "color"
},
"normal": {
"value": "{bg.absolute.black.lighter}",
"type": "color"
}
}
}
Loading
Loading