Issue #16836: New Check HexLiteralCase #17233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romani
requested changes
Jun 22, 2025
There was a problem hiding this comment.
thanks a lot,
Please read and watch videos at Starting_Development.
Please make CI green. There are videos on CI handling.
items:
| package resources.com.puppycrawl.tools.checkstyle.checks.hexliteralcase; | ||
|
|
||
| public class InputHexLiteralCaseCheck { | ||
| int i = 0xabc; // violation 'Should use uppercase hexadecimal digit instead of 'a, b, c'.' |
There was a problem hiding this comment.
I think we can remove instead of 'a, b, c' from message of Check, it is confusing.
Should use uppercase hexadecimal letters.
| @@ -5,6 +5,7 @@ descendant.token.sum.max=Общее количество {0} превышает | |||
| descendant.token.sum.min=Общее количество {0} меньше, чем минимум {1} для ''{2}''. | |||
| final.parameter=Параметр {0} должен быть final. | |||
| forbid.escaped.unicode.char=Избегайте использования экранирующих символов Unicode. | |||
| hex.Literal=??????? ???????????? ????????????????? ????? ? ??????? ???????? ?????? ''{0}''. | |||
There was a problem hiding this comment.
try to use uncode.
same for others.
| import com.puppycrawl.tools.checkstyle.api.TokenTypes; | ||
|
|
||
| /** | ||
| * <div>Checks that hexadecimal literals are defined using uppercase letters (A–F) |
There was a problem hiding this comment.
(A�F) lets avoid unicode here.
| * </li> | ||
| * </ul> | ||
| * | ||
| * @since null |
| @@ -0,0 +1,76 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
there should be template file that will generate src/site/xdoc/checks/misc/hexliteralcase.xml ,please create it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16836
New HexLiteralCase check that verifies hexadecimal number literals contain only uppercase letters (A–F). If any lowercase letters are found, a violation is raised with the message:
Should use uppercase hexadecimal digit instead of ''{0}''where {0} is replaced with that violated digits.