Skip to content

Added default locale to avoid tests failed on non-English machine. #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 3, 2024
Merged

Added default locale to avoid tests failed on non-English machine. #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aed9f14
Added default locale to avoid tests failed on non-English machine.
asakaxgit Sep 1, 2024
01fe1f2
downgrade target to Java 1.8
asakaxgit Sep 1, 2024
0ae41b1
Revert "downgrade target to Java 1.8"
asakaxgit Sep 3, 2024
d52dfdc
Fixed period year in header.
asakaxgit Sep 3, 2024
52d2291
header url changed
asakaxgit Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/checkstyle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
checkstyle.suppressions.file=config/suppressions.xml
checkstyle.suppressions-xpath.file=config/suppressions.xml
checkstyle.header.file=https://raw.githubusercontent.com/checkstyle/checkstyle/master/config/java.header
checkstyle.regexp.header.file=https://raw.githubusercontent.com/checkstyle/checkstyle/master/config/java_regexp.header
checkstyle.regexp.header.file=https://raw.githubusercontent.com/checkstyle/checkstyle/master/config/java-regexp.header
checkstyle.importcontrol.file=config/import-control.xml
checkstyle.importcontroltest.file=config/import-control-test.xml
5 changes: 4 additions & 1 deletion src/test/java/com/puppycrawl/tools/checkstyle/filters/AbstractPatchFilterEvaluationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
///////////////////////////////////////////////////////////////////////////////////////////////
// checkstyle: Checks Java source code and other text files for adherence to a set of rules.
// Copyright (C) 2001-2022 the original author or authors.
// Copyright (C) 2001-2024 the original author or authors.
//
// This library is free software; you can redistribute it and/or
// modify it under the terms of the GNU Lesser General Public
Expand Down Expand Up @@ -34,6 +34,7 @@
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.Locale;
import java.util.stream.Collectors;

import com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport;
Expand All @@ -51,6 +52,8 @@ abstract class AbstractPatchFilterEvaluationTest extends AbstractModuleTestSuppo

protected void testByConfig(String configPath)
throws Exception {
Locale.setDefault(Locale.ENGLISH);

final String inputFile = configPath.replaceFirst(
"(default|zero)ContextConfig.xml", "");
// we can add here any variable to provide path to patch name by PropertiesExpander
Expand Down