Skip to content

Fix hide images, that doesn't do what you'd expect #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

honoredup
Copy link

Hello,

I recently encountered a problem with the “Hide Images” feature in the “Images” panel.
Currently, the feature applies a CSS rule as follows: img { display: none !important; }
The problem I face is that some people in my company (and other companies that we work with) use this feature to simulate accessibility scenarios. However, in real-world cases where someone blocks image loading (for example, by using the image blocking feature in the Privacy and security panel of the web browser settings), the HTML tag remains in the DOM, even if the image content is blocked and doesn’t load. As a result, other CSS properties of the element are still applied, such as a background-color, which provides a fallback for scenarios like long loading times or other use cases (and allows text on the image to remain legible with a proper contrast).
I've seen that you already have another feature called “Make images invisible” that would work much better for what they're trying to do. Unfortunately, they don't look any further than the first button that allows them to hide the images. For the sake of clarity for non-technical users, I propose to rename the following two elements:
Hide Images → Remove Images
Make Images Invisible → Hide Images

Thank you very much in advance :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant