Skip to content

add json error message #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

divinity76
Copy link
Contributor

@divinity76 divinity76 commented Jul 29, 2025

while looking into #666 i got

PHP Fatal error: Uncaught HeadlessChromium\Exception\CommunicationException\CannotReadResponse: Response from chrome remote interface is not a valid json response. JSON error: 10 in /home/hans/projects/misc/vendor/chrome-php/chrome/src/Communication/Connection.php:382

But the message string may contain more valuable data, such as

Single unpaired UTF-16 surrogate in unicode escape

There is not a specific json error id for "unpaired UTF-16 surrogate",
thus that information was lost prior to this patch.

while looking into chrome-php#666
i got
> PHP Fatal error:  Uncaught HeadlessChromium\Exception\CommunicationException\CannotReadResponse: Response from chrome remote interface is not a valid json response. JSON error: 10 in /home/hans/projects/misc/vendor/chrome-php/chrome/src/Communication/Connection.php:382
@GrahamCampbell
Copy link
Member

I'd prefer this approach: #705.

@divinity76
Copy link
Contributor Author

I'd prefer this approach: #705.

LGTM

@divinity76 divinity76 closed this Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants