Skip to content

Conversation

robertcli
Copy link

Review for Jeff

@robertcli
Copy link
Author

Latest commit contains SpotlessApply.

@robertcli
Copy link
Author

I reversed the order of the history and undo(changes, key, record) is now undoing results accurately. Also: added <= to while loop.

NORMAL: 1565204100041001 ADD hi AS 5 (INTEGER) IN 1 AT 1565204100041001
NORMAL: 1565204154077001 REMOVE hi AS 5 (INTEGER) IN 1 AT 1565204154077001
NORMAL: 1565204154078000 ADD hi AS bye (STRING) IN 1 AT 1565204154078000
NORMAL: 1565282665359000 ADD hi AS 5 (INTEGER) IN 1 AT 1565282665359000
NORMAL: 1565282665363000 REMOVE hi AS bye (STRING) IN 1 AT 1565282665363000

REVERSE: 1565282665363000 REMOVE hi AS bye (STRING) IN 1 AT 1565282665363000
REVERSE: 1565282665359000 ADD hi AS 5 (INTEGER) IN 1 AT 1565282665359000
REVERSE: 1565204154078000 ADD hi AS bye (STRING) IN 1 AT 1565204154078000
REVERSE: 1565204154077001 REMOVE hi AS 5 (INTEGER) IN 1 AT 1565204154077001
REVERSE: 1565204100041001 ADD hi AS 5 (INTEGER) IN 1 AT 1565204100041001

@jtnelson
Copy link
Member

@robertcli you should write some unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants