Skip to content

Consider use index for db search when it's in memory and search index is not #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Consider use index for db search when it's in memory and search index is not #547

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53ee404
add TODO note for search...
jtnelson Apr 12, 2025
cfba3e1
Revert "add TODO note for search..."
jtnelson Apr 12, 2025
1209bed
Add TODO note
jtnelson Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions concourse-server/src/main/java/com/cinchapi/concourse/server/storage/db/Database.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,6 +731,10 @@ public Map<Long, List<String>> review(String key, long record) {

@Override
public Set<Long> search(String key, String query) {
// TODO: should we consider first checking if the index for key is in
// memory and using that instead of loading the corpus record. If
// ENABLE_SEARCH_CACHE is true then also check if there exist caches for
// key?
// NOTE: Locking must happen here since CorpusRecords are not cached and
// search potentially works across multiple ones.
masterLock.readLock().lock();
Expand Down