-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat(game/five): save pure level #3471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, but as additional challenge I want to suggest you to also implement logic to pass players with higher pure level on server. Currently pure level should be strictly equal to server pure level, but server do not lose anything if joining player has pure2 and server is on pure0.
Gonna do when I get home 👍 |
I'm a bit worried about how this may come off as confusing for players that switch between pure and non-pure servers. Imagine the following scenario:
Feels confusing that after joining a pure mode server, your first join on a non-pure mode server will have mods disabled for no reason, but subsequent joins will work fine. |
Hmmm, we can do something like this: when player's connecting to server without changing game build and user pure level >= server pure level we would ask him if he would like to change the pure mode. If no, he will continue with current one, if yes, game will restart. When player has to change game build, we will change the pure level automatically. |
I think it makes sense to ask players if they want to lower their puremode level with automatic skip after 5 seconds and load with puremode |
200ed74
to
b720d1a
Compare
b720d1a
to
ba81811
Compare
@prikolium-cfx can you review and test latest commit? |
Goal of this PR
This PR saves players time when connecting to servers with
sv_pureLevel
> 0. Currently, joining such servers requires a game restart every time, and this change eliminates that need.How is this PR achieving the goal
Save pure level to
CitizenFX.ini
to avoid game restart when joining pure serversThis PR applies to the following area(s)
FiveM
Successfully tested on
Platforms: Windows
Checklist