Issue #3526953 by richardgaunt, fionamorrison23, iulianrotaru, joshua1234511: ct-align class overwriting align-center #1397
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // | ||
| // This file contains styles for the CKEditor component in CivicTheme. | ||
| // | ||
|
|
||
| .ct-figure { | ||
| &.align-left, | ||
| &.align-center, | ||
| &.align-right { | ||
| display: block; | ||
| margin-block-start: ct-particle(2); | ||
| margin-block-end: ct-particle(2); | ||
| margin-inline-start: ct-particle-px(5); | ||
| margin-inline-end: ct-particle-px(5); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,3 +7,4 @@ | |
| // These overrides will not be visible in the Storybook. | ||
| @import 'page/page'; | ||
| @import 'header/header'; | ||
| @import 'ckeditor/ckeditor'; | ||
|
There was a problem hiding this comment. The issue is specific to Drupal’s creditor classes, and therefore, it was more appropriate to handle it as a Drupal-specific override. Hence not added via UIKit. There was a problem hiding this comment. @alan-cole This is best answered - will this cause issues if we have this included in the base Drupal CSS? From my mind no. |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how these changes could fix the issue.
Can you provide screenshots showing how these changes fix the alignment issues mentioned in the ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ct-figure removes the styles which are needed for align-center align-right
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is quite working properly.
Looking at the screenshot, it looks like the "center" aligned image is really just left aligned, but sitting indented, and flush against the left aligned image.
If you look at the screenshot below, the center would be slightly different if it was sitting properly in the center: