-
Notifications
You must be signed in to change notification settings - Fork 21
[#3547385] Removed component namespaces. #1425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughRemoved component namespace declarations from two CivicTheme .info.yml files and changed the page layout include from Changes
Sequence Diagram(s)sequenceDiagram
participant Renderer as Theme renderer
participant Old as @templates/page/page.twig
participant New as civictheme:page
rect rgb(230,240,255)
Note right of Renderer: Previous flow
Renderer->>Old: include '@templates/page/page.twig'
Old-->>Renderer: render page template
end
rect rgb(230,255,230)
Note right of Renderer: New flow
Renderer->>New: include 'civictheme:page'
New-->>Renderer: render page template
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
JIRA ticket: #3547385
Checklist before requesting a review
Changed
Screenshots
Summary by CodeRabbit
Refactor
Chores
Documentation