-
Notifications
You must be signed in to change notification settings - Fork 394
chore(astro): Update dependency astro to v5.14.3 [SECURITY] #6966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
8628ad2
to
055e17d
Compare
055e17d
to
85bbadd
Compare
85bbadd
to
6913da6
Compare
6913da6
to
3e8aac9
Compare
3e8aac9
to
ea8abf4
Compare
ea8abf4
to
cae9d27
Compare
cae9d27
to
d75d3f4
Compare
d75d3f4
to
c316090
Compare
c316090
to
47c41a5
Compare
47c41a5
to
22d62c3
Compare
22d62c3
to
f882f6d
Compare
f882f6d
to
48fceee
Compare
This PR contains the following updates:
5.14.1
->5.14.3
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
GitHub Vulnerability Alerts
CVE-2025-61925
Summary
When running Astro in on-demand rendering mode using a adapter such as the node adapter it is possible to maliciously send an
X-Forwarded-Host
header that is reflected when using the recommendedAstro.url
property as there is no validation that the value is safe.Details
Astro reflects the value in
X-Forwarded-Host
in output when usingAstro.url
without any validation.It is common for web servers such as nginx to route requests via the
Host
header, and forward on other request headers. As such as malicious request can be sent with both aHost
header and anX-Forwarded-Host
header where the values do not match and theX-Forwarded-Host
header is malicious. Astro will then return the malicious value.This could result in any usages of the
Astro.url
value in code being manipulated by a request. For example if a user follows guidance and usesAstro.url
for a canonical link the canonical link can be manipulated to another site. It is not impossible to imagine that the value could also be used as a login/registration or other form URL as well, resulting in potential redirecting of login credentials to a malicious party.As this is a per-request attack vector the surface area would only be to the malicious user until one considers that having a caching proxy is a common setup, in which case any page which is cached could persist the malicious value for subsequent users.
Many other frameworks have an allowlist of domains to validate against, or do not have a case where the headers are reflected to avoid such issues.
PoC
nvm use
yarn run build
node ./dist/server/entry.mjs
curl --location 'http://localhost:4321/' --header 'X-Forwarded-Host: www.evil.com' --header 'Host: www.example.com'
X-Forwarded-Host
headerFor the more advanced / dangerous attack vector deploy the application behind a caching proxy, e.g. Cloudflare, set a non-zero cache time, perform the above
curl
request a few times to establish a cache, then perform the request without the malicious headers and observe that the malicious data is persisted.Impact
This could affect anyone using Astro in an on-demand/dynamic rendering mode behind a caching proxy.
Release Notes
withastro/astro (astro)
v5.14.3
Compare Source
Patch Changes
#14505
28b2a1d
Thanks @matthewp! - FixesCannot set property manifest
error in test utilities by adding a protected setter for the manifest property#14235
c4d84bb
Thanks @toxeeec! - Fixes a bug where the "tap" prefetch strategy worked only on the first clicked link with view transitions enabledConfiguration
📅 Schedule: Branch creation - "" in timezone GMT, Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.