WIP: teams #3334
Draft
WIP: teams #3334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow re-use for private override.
kim
commented
Oct 8, 2025
crates/cli/src/subcommands/delete.rs
Outdated
Comment on lines
78
to
99
| pub fn print_database_tree_info(&self, mut out: impl io::Write) -> anyhow::Result<()> { | ||
| let fmt_names = |names: &BTreeSet<String>| match names.len() { | ||
| 0 => <_>::default(), | ||
| 1 => format!(": {}", names.first().unwrap()), | ||
| _ => format!(": {names:?}"), | ||
| }; | ||
|
|
||
| let tree_info = &self.database_tree; | ||
|
|
||
| write!(out, "{}{}", tree_info.root.identity, fmt_names(&tree_info.root.names))?; | ||
| for (identity, info) in &tree_info.children { | ||
| let names = fmt_names(&info.names); | ||
| let parent = info | ||
| .parent | ||
| .map(|parent| format!(" (parent: {parent})")) | ||
| .unwrap_or_default(); | ||
|
|
||
| write!(out, "{identity}{parent}{names}")?; | ||
| } | ||
|
|
||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
@aasoni I have been a little un-imaginative about how to render the tree of children when trying to delete a parent. Note also that a database can have more than one name.
If you have a specific idea of how this should be rendered, please let me know.
There was a problem hiding this comment.
I'm just getting to this. I think it's fine to do "something" and improve it later if we feel strongly about it. This isn't a very common subcommand in people's workflows.
There was a problem hiding this comment.
I have changed this to render a tree (like the tree command), unless --yes is given:
0000000000000000000000000000000000000000000000000000000000000001: parent
├── 0000000000000000000000000000000000000000000000000000000000000004: bro, sibling
└── 0000000000000000000000000000000000000000000000000000000000000002: child
├── 0000000000000000000000000000000000000000000000000000000000000005
└── 0000000000000000000000000000000000000000000000000000000000000003: grandchild
We could abbreviate the identities if, and only if, there are no collisions. I'll leave that as a future exercise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP