-
Notifications
You must be signed in to change notification settings - Fork 616
Remove use of DDC during CI tests #3367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
? |
Can you add some explanation (maybe inline comments) about what impact these settings make? |
Of course! I've added to the latest commit, let me know if the write up makes sense or if it needs more detail! |
It looks like we're still getting SIGSEGV sometimes, but if you feel confident that this will decrease the frequency, I'm all for it.
(https://github.com/clockworklabs/SpacetimeDB/actions/runs/18387938924/job/52727623047) |
Oh that actually is a different error, setrlimit() is attempting to get some sort of resource increased but wasn't able. I'd guess memory would be a culprit here but I'm not 100% certain. I'll run some more tests on Linux and see if IO or Memory are higher than I expect. |
Okay perfect, then it sounds like this PR is still at least an improvement. I'll approve as-is! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of Changes
Removes the use of the Derived Data Cache during CI, will in
API and ABI breaking changes
None
Expected complexity level and risk
1 - Small change for CI
Testing