V8: prepare for JS workers #3395
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…module. This prefers the "global this" as it will become most common based on our chosen UX. There is also a fallback added. This also prepares for a js-worker thread that will stay alive as long as the database does. The aforementioned fallback will only be used on module startup once the js-worker is used.
Centril
force-pushed
the
centril/v8-js-worker-prepare
branch
from
68afdfd to
74db206
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR refactors various things in preparation for adding JS workers.
The changes are useful on their own without said workers and they are also their own PR for ease of review.
v8crate.x__describe_module__and__call_reducer__first in the global object and then fallback to the module object. As per the changed design constraints for better UX (bundling and so on...).API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
Mostly covered by existing tests...
Also, future work.