feat: worker fetch example #411
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kflansburg
previously approved these changes
Feb 28, 2024
kflansburg
approved these changes
Feb 28, 2024
guybedford
reviewed
Sep 3, 2025
| #[event(fetch)] | ||
| pub async fn main(req: Request, env: Env, _ctx: Context) -> Result<Response> { | ||
| Router::new() | ||
| .get_async("/pokemon/:name", handle_single) |
There was a problem hiding this comment.
Can we call this pokemon_route_handler, get_pokemon or something that makes it clearer the function is the route handler?
| @@ -0,0 +1,21 @@ | |||
| use worker::{event, Context, Env, Fetch, Request, Response, Result, RouteContext, Router, Url}; | |||
|
|
|||
| const ENDPOINT: &str = "https://pokeapi.co/api/v2/pokemon"; | |||
There was a problem hiding this comment.
Again, more descriptive would help:
Suggested change
| const ENDPOINT: &str = "https://pokeapi.co/api/v2/pokemon"; | |
| const POKEMON_API_URL: &str = "https://pokeapi.co/api/v2/pokemon"; |
Comment on lines
+5
to
+13
| async fn fetch_pokemon(url_string: &str) -> Result<Response> { | ||
| // construct a new Url | ||
| let url = Url::parse(url_string)?; | ||
| Fetch::Url(url).send().await | ||
| } | ||
|
|
||
| async fn handle_single(_: Request, ctx: RouteContext<()>) -> Result<Response> { | ||
| Ok(fetch_pokemon(&format!("{ENDPOINT}/{}", ctx.param("name").unwrap())).await?) | ||
| } |
There was a problem hiding this comment.
This seems like it would be easier to read and follow as a single function implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a simple example on using worker::Fetch to fetch external API in Cloudflare Workers