Skip to content

fix: add CostReport Status EXPIRED #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

jinyoungmoonDEV
Copy link
Contributor

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

  • add CostReport Status EXPIRED

Signed-off-by: jinyoungmoonDEV <[email protected]>
@jinyoungmoonDEV jinyoungmoonDEV requested a review from Copilot June 13, 2025 01:57
@jinyoungmoonDEV jinyoungmoonDEV merged commit 02cad1b into cloudforet-io:master Jun 13, 2025
3 checks passed
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new global Status enum to include an EXPIRED state for CostReport while removing duplicate status definitions in message types to centralize status management.

  • Introduces a global Status enum with an additional EXPIRED value.
  • Removes inline Status enums from CostReportQuery and CostReportInfo messages.
  • Improves maintainability by reducing duplicated code.
Comments suppressed due to low confidence (2)

proto/spaceone/api/cost_analysis/v1/cost_report.proto:56

  • [nitpick] Consider adding a descriptive comment for the EXPIRED status to clarify the intended meaning and usage conditions for future maintainability.
EXPIRED = 4;

proto/spaceone/api/cost_analysis/v1/cost_report.proto:51

  • Centralizing the CostReport status definitions into a new global enum improves maintainability. Please ensure all references to the previous inline enums are updated to use this new global enum.
enum Status {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant