Skip to content

Add input validation to support dynamic changes to gorouter log level #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

navinms711
Copy link

Summary

The changes here are to support the dynamic changing of gorouter logging level at runtime. There is also an associated PR in routing-release repo cloudfoundry/routing-release#495

Backward Compatibility

Breaking Change? No

@navinms711 navinms711 requested a review from a team as a code owner June 20, 2025 09:11
Copy link

CLA Not Signed

Copy link
Member

@ameowlia ameowlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love all the extra validation!

Can you add tests here for all of the new error cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants