Revert"Revert "fix UPS defined as existing service resources are not working" #1687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… working" (cloudfoundry#1684)" This reverts commit 7995b80.
stiv03
changed the title
Comment on lines
81
to
84
| public static boolean isExistingUserProvidedService(Resource resource, CloudControllerClient client) { | ||
| CloudServiceInstance serviceInstance = client.getServiceInstanceWithoutAuxiliaryContent(NameUtil.getServiceName(resource), false); | ||
| return serviceInstance != null && serviceInstance.isUserProvided(); | ||
| } |
There was a problem hiding this comment.
This function does too many things, gets the service instance, checks for null, for user provided, etc, got the idea.
You can remove it and make proper checks in the function where this function is invoked and split them in small functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.