cmake-based build for fastjet-contrib (cmake requires fastjet >=3.5.0, siscone >=3.1.1 also built with cmake) #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @lgray for branch cms/v1.101. @akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
lgray
changed the title
lgray
changed the title
|
@smuzaffar any major reservations against this? |
This was referenced Jun 11, 2025
Merged
|
Pull request #19 was updated. |
|
Pull request #19 was updated. |
|
Pull request #19 was updated. |
|
Pull request #19 was updated. |
|
Pull request #19 was updated. |
|
Pull request #19 was updated. |
|
Pull request #19 was updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Making this PR in case it is of interest for CMS. The cmake install vastly simplifies the building and management of python bindings built here: https://github.com/scikit-hep/fastjet, perhaps similar justification exists here.
It's root-dir only + patchset for windows so that the code changes are minimal and it's easy to continue merging with updates from fjcontrib. The root CMakeLists.txt generates all subsequently required CMakeLists.txts in subdirectories. I have tested this on linux (x86 and arm), macos, and windows. All tests we could run pass.
Example configuration command, assuming fastjet and siscone are not in the CMAKE_PREFIX_PATH:
Presently this PR does not change the build process for the cms-external away from autotools, but merely enables the possibility of using cmake.