-
Notifications
You must be signed in to change notification settings - Fork 224
Add field descriptions to product_recommendation example #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add field descriptions to product_recommendation example #1152
Conversation
taxonomies: list[ProductTaxonomy] | ||
complementary_taxonomies: list[ProductTaxonomy] | ||
taxonomies: list[ProductTaxonomy] = dataclasses.field( | ||
metadata={"description": "Taxonomies for the current product."} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the standard way to add description for fields.
Please convert these dataclasses to Pydantic models.
Please also test these field descriptions are passed to LLM as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI, thanks for the review!. I noticed the original code used dataclasses for all the defined classes, and my assigned issue (#1088) asked to add field descriptions for the product recommendation example.
Just to confirm - you'd like me to convert these dataclasses to Pydantic models so the field descriptions are correctly recognized by the system?
Thanks again for your guidance!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey |
resolves #1088