Skip to content

fix(Pagination): Allow usage of Pagination component with Next.js #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2024
Merged

fix(Pagination): Allow usage of Pagination component with Next.js #273

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13105de
fix: Pagination component for Next.js
Jul 10, 2024
6f13fc2
typo: changed `first` to `previous` in file
DavidFrancois Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 66 additions & 41 deletions src/Pagination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { memo, forwardRef, type CSSProperties } from "react";
import React, { memo, forwardRef, type CSSProperties, ReactNode } from "react";
import { symToStr } from "tsafe/symToStr";
import { assert } from "tsafe/assert";
import type { Equals } from "tsafe";
Expand All @@ -8,6 +8,18 @@ import { createComponentI18nApi } from "./i18n";
import { RegisteredLinkProps, getLink } from "./link";
import { useAnalyticsId } from "./tools/useAnalyticsId";

const DynamicLink = ({
useReactLinkComponent,
children,
...rest
}: {
useReactLinkComponent: boolean;
children: ReactNode;
}) => {
const { Link } = getLink();
return useReactLinkComponent ? <Link {...rest}>{children}</Link> : <a {...rest}>{children}</a>;
};

export type PaginationProps = {
id?: string;
className?: string;
Expand Down Expand Up @@ -100,36 +112,43 @@ export const Pagination = memo(
<ul className={cx(fr.cx("fr-pagination__list"), classes.list)}>
{showFirstLast && (
<li>
<Link
<DynamicLink
useReactLinkComponent={defaultPage > 1}
{...(count > 0 && defaultPage > 1 && getPageLinkProps(1))}
className={cx(
fr.cx("fr-pagination__link", "fr-pagination__link--first"),
classes.link,
getPageLinkProps(1).className
)}
aria-disabled={count > 0 && defaultPage > 1 ? true : undefined}
role="link"
{...{
className: cx(
fr.cx("fr-pagination__link", "fr-pagination__link--first"),
classes.link,
getPageLinkProps(1).className
),
"aria-disabled":
count > 0 && defaultPage > 1 ? true : undefined,
role: "link"
}}
>
{t("first page")}
</Link>
</DynamicLink>
</li>
)}
<li>
<Link
className={cx(
fr.cx(
"fr-pagination__link",
"fr-pagination__link--prev",
"fr-pagination__link--lg-label"
),
classes.link
)}
<DynamicLink
useReactLinkComponent={defaultPage > 1}
{...(defaultPage > 1 && getPageLinkProps(defaultPage - 1))}
aria-disabled={defaultPage <= 1 ? true : undefined}
role="link"
{...{
className: cx(
fr.cx(
"fr-pagination__link",
"fr-pagination__link--prev",
"fr-pagination__link--lg-label"
),
classes.link
),
"aria-disabled": defaultPage <= 1 ? true : undefined,
role: "link"
}}
>
{t("previous page")}
</Link>
</DynamicLink>
</li>
{parts.map(part => (
<li key={part.number}>
Expand All @@ -150,34 +169,40 @@ export const Pagination = memo(
</li>
))}
<li>
<Link
className={cx(
fr.cx(
"fr-pagination__link",
"fr-pagination__link--next",
"fr-pagination__link--lg-label"
),
classes.link
)}
<DynamicLink
useReactLinkComponent={defaultPage < count}
{...(defaultPage < count && getPageLinkProps(defaultPage + 1))}
aria-disabled={defaultPage < count ? true : undefined}
role="link"
{...{
className: cx(
fr.cx(
"fr-pagination__link",
"fr-pagination__link--next",
"fr-pagination__link--lg-label"
),
classes.link
),
"aria-disabled": defaultPage < count ? true : undefined,
role: "link"
}}
>
{t("next page")}
</Link>
</DynamicLink>
</li>
{showFirstLast && (
<li>
<Link
className={cx(
fr.cx("fr-pagination__link", "fr-pagination__link--last"),
classes.link
)}
<DynamicLink
useReactLinkComponent={defaultPage < count}
{...(defaultPage < count && getPageLinkProps(count))}
aria-disabled={defaultPage < count ? true : undefined}
{...{
className: cx(
fr.cx("fr-pagination__link", "fr-pagination__link--last"),
classes.link
),
"aria-disabled": defaultPage < count ? true : undefined
}}
>
{t("last page")}
</Link>
</DynamicLink>
</li>
)}
</ul>
Expand Down