Skip to content

Fix usage of div in CallOut #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix usage of div in CallOut #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CallOut.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export const CallOut = memo(
{title}
</HtmlTitleTag>
)}
<p className={cx(fr.cx("fr-callout__text"), classes.text)}> {children} </p>
<div className={cx(fr.cx("fr-callout__text"), classes.text)}> {children} </div>
{buttonProps !== undefined && (
<Button
{...buttonProps}
Expand Down
6 changes: 3 additions & 3 deletions stories/CallOut.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const { meta, getStory } = getStoryFactory({
export default meta;

export const Default = getStory({
"title": "Titre mise en avant",
"title": "Titre mis en avant",
"iconId": "ri-information-line",
"children": `Les parents d’enfants de 11 à 14 ans n’ont aucune démarche à
accomplir : les CAF versent automatiquement l’ARS aux familles déjà allocataires
Expand All @@ -96,7 +96,7 @@ export const NoTitle = getStory({
});

export const NoIcon = getStory({
"title": "Titre mise en avant",
"title": "Titre mis en avant",
"children": `Les parents d’enfants de 11 à 14 ans n’ont aucune démarche à
accomplir : les CAF versent automatiquement l’ARS aux familles déjà allocataires
qui remplissent les conditions.`,
Expand All @@ -108,7 +108,7 @@ export const NoIcon = getStory({
});

export const NoButton = getStory({
"title": "Titre mise en avant",
"title": "Titre mis en avant",
"iconId": "ri-information-line",
"children": `Les parents d’enfants de 11 à 14 ans n’ont aucune démarche à
accomplir : les CAF versent automatiquement l’ARS aux familles déjà allocataires
Expand Down