-
Notifications
You must be signed in to change notification settings - Fork 77
feat: Ajout des pictogrammes du DSFR đź’Ž V2 #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Maxence Gama <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the new PR.
Please clean the diff and I'll merge and release :)
👌 |
I believe we need to revert this PR, as it doesn't comply with the DSFR pictogram structure.
Currently, this implementation does not support dark mode nor color variants, both of which are required for proper DSFR theming. |
@ddecrulle Indeed I based my code on the Figma library and completely I forgot the class name and aria props. Regarding the SVG architecture, using instead of inline paths, I thought it was more relevant in a React context, but after further consideration and considering the comments, it was a mistake. |
@ddecrulle In the context of a react package that needs to be easily exported and optimized by a compiler, the approach of using static files and references to symbols in those files doesn't seem very relevant to me. This means that every project using Based on this observation, I suggest using inline svgs, taking care to group their paths as recommended, as well as the classes and attributes required by the DSFR. |
Prise en compte des changements demandés dans la PR #413
La version de React avait été changé par le gestionnaire de paquets en installant les nouveaux paquets, le problème a été réglé et la version est de retour à sa version initiale.