-
Notifications
You must be signed in to change notification settings - Fork 24
First stage of work on codemeta #67 - moving to bootstrap v 5.x #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: refresh-2025
Are you sure you want to change the base?
Conversation
Also update Trove link to one from Wayback Machine (the original one no longer works) Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Reimplemented what described here: codemeta#37 (comment) to reduce confusion of duplicated appearance of terms in the same table. Signed-off-by: Arthit Suriyawongkul <[email protected]>
Split Person and Thing terms into a separate table
Add missing crosswalk intros
Also remove "untitled folder" in img/ (a copy of the img directory itself)
This brings in Bootstrap 5.3.8, JQuery 3.7.1, and removes all except the material-kit.css "Product Page" file which forms the basis of the current theme of CodeMeta's website.
This prepares us for cleaning up the extra/duplicate static assets.
This directory included image files which after investigation were deemed not in current use on the website and could be safely removed. If this assertion is wrong and they are needed later, this commit can be reverted without harm to the current theme, or the images can be retrieved from git history.
Glyphicon.css is no longer necessary in Bootstrap 5.x, and the duplicated material-kit was a hack to change the theme base color to blue from purple.
material-kit.js no longer calls bootstrapMaterialDesign which seems neither compatible with current bootstrap nor maintained.
Turns out the material.kit js was still useful for the responsive navigation. Rather than re-implement that I've restored it and commented out the call to additional js which is no longer compatible. |
Thanks! I gave it a try and I could barely tell the difference. Just one thing: https://codemeta.github.io/ had a "Next »" button that doesn't show up here. Can this be fixed easily? If not we can probably address it later by finding a better way to list crosswalks (and probably list them on all the same page instead of paginating) |
Default mode is either system preference if supported, or light mode if not. Highlight.js removed from config.toml as it did not seem to be in use. The "monokai" theme for codeblocks has been changed to "pygments" theme to support dark/light mode switching. It's not amazing on dark mode but it's better than eye strain.
We discussed this elsewhere, and the framework swap simply (and sensibly!) moved the link to the bottom. I haven't spent time to check why, since the front page is not going to stay as a wall-o-text with a paginated sitemap :) |
I've now also implemented dark/light mode switching! You should see a little icon at the end/bottom of the navigation. It defaults to system preference (if supported) or light mode. Note: this does not affect the generator page. ...and in the process of doing that I noticed the replacement transparent nav transition js needed to be tweaked for page reloads, which is now done and rebased ahead of the mode commit. Next week, the layouts! |
My system is dark mode and this is correctly detected by some websites (using |
Additionally, when restoring the "dark" state from local storage, the icon is not updated accordingly |
works for me now! |
Replaced framework with the latest Bootstrap & JQuery and
removed unused Material-Kit assets. Retained material-kit.css
to preserve the familiar appearance and save time.
Default theme now CodeMeta-Pyramids.