feat: add universal image #307
Open
+38
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
reviewed
Aug 19, 2025
| RUN yes | npx playwright install chrome | ||
|
|
||
| # Create `coder` user | ||
| RUN userdel -r codespace && \ |
There was a problem hiding this comment.
I think deluser leaves the user's home directory.
You should use userdel --remove-all-files --remove-home
I am not sure how this will behave with all installed tools from the base image though.
Or better rename the user and move over the existing home directory
RUN usermod -l coder codespace \
&& usermod -d /home/coder -m coder \
&& groupmod -n coder codespace
There was a problem hiding this comment.
I confirmed userdel doesn't keep the home folder!
There was a problem hiding this comment.
I will build and test before approving. Can do today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a universal image with many packages and dependencies pre-installed. cleaned up PR