Skip to content

Conversation

CodeMan62
Copy link
Contributor

@CodeMan62 CodeMan62 commented Aug 24, 2025

Closes #34

Description

Jfrog Modules doesn't support conda package manager, This PR adds support of that

Type of Change

  • Feature/enhancement
  • Documentation

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun run fmt)
  • Changes tested locally

Related Issues

#34
/claim #34

@CodeMan62 CodeMan62 changed the title add conda to Jfron modules add conda to Jfrog modules Aug 24, 2025
@matifali
Copy link
Member

matifali commented Aug 25, 2025

The code looks good can you please attach a video demo of this working in a Coder workspace? The conda package manager should show package resolution from the configured artifactory instance.

@CodeMan62
Copy link
Contributor Author

I believe by "Cider" you mean "Coder" I am making a video for that

@CodeMan62
Copy link
Contributor Author

CodeMan62 commented Aug 25, 2025

Screencast.from.2025-08-25.22-23-13.mp4

Everything is working fine the main reason it fails is you can see that i am having a jfrog(docker) not the real creds.

@matifali matifali removed the request for review from DevelopmentCats August 25, 2025 18:29
@CodeMan62
Copy link
Contributor Author

Is it going to merge or anything left here??

@matifali
Copy link
Member

@CodeMan62 testing it now.

@matifali matifali requested review from matifali and Copilot August 26, 2025 07:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds conda package manager support to the JFrog modules, allowing users to configure conda repositories for package management through Artifactory.

  • Adds conda configuration support to both jfrog-token and jfrog-oauth modules
  • Creates conda configuration templates that generate .condarc files with proper authentication
  • Updates documentation and tests to include conda usage examples

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
registry/coder/modules/jfrog-token/run.sh Adds conda configuration logic to create .condarc file
registry/coder/modules/jfrog-token/main.tf Adds conda package manager variable and template configuration
registry/coder/modules/jfrog-token/main.test.ts Adds test case for conda configuration with multiple repositories
registry/coder/modules/jfrog-token/conda.conf.tftpl Creates conda configuration template with channel URLs
registry/coder/modules/jfrog-token/README.md Updates documentation with conda usage examples
registry/coder/modules/jfrog-oauth/run.sh Adds conda configuration logic (duplicate of token module)
registry/coder/modules/jfrog-oauth/main.tf Adds conda package manager variable and template configuration
registry/coder/modules/jfrog-oauth/main.test.ts Adds test case for conda configuration
registry/coder/modules/jfrog-oauth/conda.conf.tftpl Creates conda configuration template
registry/coder/modules/jfrog-oauth/README.md Updates documentation with conda example

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@CodeMan62
Copy link
Contributor Author

I don't think we should go with these copilot suggesions as we can see in whole test file we haven't followed this pattern to put password token what do you think ??

@matifali
Copy link
Member

@CodeMan62, I am getting the following error when testing the jfrog-oauth module

Loading channels: failed

CondaHTTPError: HTTP 401 CONNECTION FAILED for url <https://example.jfrog.io/artifactory/api/conda/coder-conda/linux-64/repodata.json>
Elapsed: 00:00.442815

The credentials you have provided for this URL are invalid.

I am not sure if it's the config issue or what.

@CodeMan62
Copy link
Contributor Author

CodeMan62 commented Aug 26, 2025

The simple problem is the url you gave here is not valid it is not a config issue
url should be something like this https://.jfrog.io/artifactory

@matifali
Copy link
Member

@CodeMan62, I am not adding a URL and just using the module. The module is configuring it. Can you show a video of this working for you?

@CodeMan62
Copy link
Contributor Author

I will add it by tommorow thanks.

@CodeMan62
Copy link
Contributor Author

here is video

latest-jfrog-conda.mp4

@matifali
Copy link
Member

I don't see conda search numpy and conda install numpy working successfully from the web terminal.

You are getting a 40x error at 04:12 as per the video.

@CodeMan62
Copy link
Contributor Author

It was a very simple mistake done by me putting wrong jfrog-url here is a new video complete video:-

latestest-video-jfrog.mp4

@matifali
Copy link
Member

Still not working for me and I get the same error shared above.

@CodeMan62
Copy link
Contributor Author

CodeMan62 commented Aug 28, 2025

can you please specify what command or operation you are running?
as you said you were testing i have showed testing in the first half of video

@matifali
Copy link
Member

@CodeMan62 conda search numpy

@CodeMan62
Copy link
Contributor Author

CodeMan62 commented Aug 28, 2025

I believe the problem is credentials that's why it is happening can you please use mine ones??
can you please have a look at the your credentials they should look like these

jfrog_url = "https://example.jfrog.io"
artifactory_access_token = "ey...."
conda_repositories = ["conda-local", "conda-remote"]

@CodeMan62
Copy link
Contributor Author

one more thing we can do is can you please ask anyone else in team to test it?

@CodeMan62
Copy link
Contributor Author

@matifali any direction on it ??

@CodeMan62
Copy link
Contributor Author

@matifali please have a look the code is working and i have also provided a video I just can't reproduce the error you got if you can help me reproduce that i will just fix that as you can see the work goes smoother in video

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had an issue with my setup. Just tested again, and it works. Thank you for your contribution.

@matifali matifali changed the title add conda to Jfrog modules feat: add conda support to JFrog modules Sep 1, 2025
@CodeMan62
Copy link
Contributor Author

Thanks working on adding maven support for Jfrog modules in #33

@matifali matifali enabled auto-merge (squash) September 1, 2025 16:38
@matifali
Copy link
Member

matifali commented Sep 1, 2025

@CodeMan62 please rebase on main again

@CodeMan62
Copy link
Contributor Author

Doing it

auto-merge was automatically disabled September 1, 2025 16:45

Head branch was pushed to by a user without write access

@CodeMan62
Copy link
Contributor Author

@matifali done

@matifali matifali merged commit 7152b85 into coder:main Sep 1, 2025
4 checks passed
@matifali matifali added the version:minor Add to PRs requiring a minor version upgrade label Sep 1, 2025
@matifali
Copy link
Member

matifali commented Sep 1, 2025

@CodeMan62 We forgot to update the module version. Can you do a follow-up now to update both modules by 1 minor version?

@CodeMan62
Copy link
Contributor Author

for sure let me just do it

matifali pushed a commit that referenced this pull request Sep 1, 2025
Closes #

## Description

## Type of Change

- [ ] New module
- [ ] Bug fix
- [ ] Feature/enhancement
- [ ] Documentation
- [x] Other

## Testing & Validation

- [x] Tests pass (`bun test`)
- [x] Code formatted (`bun run fmt`)
- [x] Changes tested locally

## Related Issues
Follow up of #375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim version:minor Add to PRs requiring a minor version upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JFrog: Add conda package manager support to JFrog modules
2 participants