Scroller mode and full width for teaser lists #2242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tf
force-pushed
the
teaser-scroller
branch
3 times, most recently
from
1afe817 to
7af3184
Compare
- Make different content max widths available as custom properties - including defaults set by different layouts. - Make content-max-width unset in full width instead of setting it to `none`. This allows using different fallback values in vars. - Do not reset `content-margin` for full width elements. So far, `content-margin` has only be used in the non full width case. Keeping it unchanged lets full width element align children with content margin. REDMINE-20981
Behind feature flag for now. REDMINE-20981
REDMINE-20981
REDMINE-20981
- Activate custom margin to allow placing scroll buttons in content margin. - Base item width on reference width instead of container width when element has full width. This allows aligning items width different content max widths even if element spans full width. Calculate padding to align items with other section content based on content margin and section max width. - Optionally render scroller. When full width is used, apply padding as scoll padding + margin for the first and last item to make padding at the end of the scroller work. - For centered layout, initially align first and last item with section content when scroller is moved to beginning/end respectively. REDMINE-20981
Transforming a scroll snapped element moves the scroller. REDMINE-20981
REDMINE-20981
Allow rendering action button in floating portals. REDMINE-20981
- Implement based on floating-ui - Use portal to prevent clipping in teaser list scroller REDMINE-20981
REDMINE-20981
Prevent l and xl items from exceeding the width they would have if the viewport was wide enough to for the maximum number of columns to be used. REDMINE-20979
Workflow is no longer needed now that Localeapp is gone. Some of those started showing up in the UI due to recent change.
* For item widths that result in items that are less wide than the element, apply the max width to the scroller to prevent showing partial items. Center scroll in container. * Use layout widths as reference for items in full width list. REDMINE-20981
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REDMINE-20981