Skip to content

Minor fixes for project importer #5546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jul 16, 2025

  • If no test framework can be identified, default to TestModule.Junit4 to allow the build to at least compile
  • Add a space between the lazy val $lhs and the following : to avoid parsing errors when lhs ends with a _

Noticed these while trying to get MIMA imports working

@lihaoyi
Copy link
Member Author

lihaoyi commented Jul 21, 2025

Looks like the failure in example.migrating.javalib[3-maven-complete-large].packaged.daemon's page-object test suite is that it is incorrectly configured in Maven: it does not a test framework or test dependencies configured, and thus doesn't run when you use ./mvnw clean test -pl page-object -am.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant