Support ScalaNativeModule.runMain
#5723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
approved these changes
Aug 24, 2025
vaslabs
pushed a commit
to vaslabs-ltd/mill
that referenced
this pull request
Aug 26, 2025
For each main class, we need an additional linking task. Due to the fact, that we don't know the name of the main class to run before, we currently can't cache the result of the linking task for user-provided main classes. See discussion for a potential solution: * com-lihaoyi#4595 (comment) * com-lihaoyi#4595 (comment) Also replaced the directly defined `run` task by implementing `runner(): Runner`, so that users can run native mains in more situations. The `run` method is now obsolete and is kept to do the same as `super.run()` to preserve binary compatibility. Fix com-lihaoyi#5461 Pull request: com-lihaoyi#5723
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each main class, we need an additional linking task. Due to the fact, that we don't know the name of the main class to run before, we currently can't cache the result of the linking task for user-provided main classes.
See discussion for a potential solution:
Also replaced the directly defined
runtask by implementingrunner(): Runner, so that users can run native mains in more situations. Therunmethod is now obsolete and is kept to do the same assuper.run()to preserve binary compatibility.Fix #5461