Expose read-write accessors. #96
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For lastLineBlank, htmlBlockType and a `data` property which allows AST consumers to associate arbitrary data with an AST node.
|
I understand about |
|
I need to know the type of html block type under quite a few scenarios, IIRC particularly to determine if a block is a processing instruction or not. It just feels wrong to be accessing the private variables. I forget for lastLineBlank but i think it was to do with lists at the end of partials and determining whether i need to add and additional line or not. It has been a long time so i would have to read the code again... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
lastLineBlank,htmlBlockTypeand adataproperty which allows ASTconsumers to associate arbitrary data with an AST node.