Skip to content

Conversation

mashbean
Copy link

Translate the en_us.js from client-admin to Traditional Chinese zh_hant.js

@ebarry
Copy link
Contributor

ebarry commented Nov 21, 2023

Thank you for contributing this @mashbean !!!

@metasoarous
Copy link
Contributor

Hi @mashbean. Thanks again for submitting this!

I investigated a bit further, and confirmed that these "strings" files aren't actually hooked up by default the same way they are in the client-participation part of the codebase. I think the client-admin/src/pt_br.js file was submitted assuming that you would manually swap it out for the en_us.js file in client-admin/src/strings/strings.js. In fact you'll see a TODO note there about porting over the browser language detection code from client-participation.

Right now, there's no harm in me merging this as is, so it can be swapped out for en_us with a deploy code change (as with pt_br). But I figured I'd give you the chance to adapt the browser detection logic from client-participation, if you'd like this to be automated.

Please let me know which way you'd like to go on this :-)

Thanks again!

@mashbean
Copy link
Author

mashbean commented Dec 5, 2023

Hi metasoarous, I've received the mail and message. Thank you so much for correcting my error. If there are more traditional Chinese translation demands, please feel free to tag me! I am glad to be the contributor for Polis

@ballPointPenguin
Copy link
Member

We can probably just merge this

Translate the en_us.js from client-admin to Traditional Chinese
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants