-
-
Notifications
You must be signed in to change notification settings - Fork 78
Feature/virtual list #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
buckhalt
wants to merge
21
commits into
v3.0.0
Choose a base branch
from
feature/virtual-list-2
base: v3.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/virtual list #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
allows parent to explicitly control animation for cases like dnd
add docs for controlling listId from parent in different situations
fixes incorrect focus shape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new, highly flexible and accessible
VirtualList
component for efficiently rendering large lists in different layouts. It also adds new dependencies to support this component and improves Storybook's accessibility testing capabilities.Component addition:
VirtualList
component inlib/ui/components/VirtualList/VirtualList.tsx
that supports grid, column, and horizontal layouts, keyboard navigation, selection, and accessibility features. It uses@tanstack/react-virtual
for performant virtualization.Dependency updates:
@tanstack/react-virtual
topackage.json
and updatedpnpm-lock.yaml
to support virtualized lists. [1] [2] [3] [4]@storybook/addon-a11y
topackage.json
andpnpm-lock.yaml
to enable accessibility checks in Storybook. [1] [2] [3] [4]Storybook configuration:
@storybook/addon-a11y
addon in.storybook/main.js
for improved accessibility testing in Storybook.